Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for failing private key formats #54

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Add tests for failing private key formats #54

merged 1 commit into from
Dec 28, 2024

Conversation

rgmz
Copy link
Owner

@rgmz rgmz commented Dec 27, 2024

Description:

TruffleHog doesn't detect a number of private keys. Ideally, it could be more robust in its detection.

Related: gitleaks/gitleaks#1594

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rgmz rgmz force-pushed the tests/privatekey branch 9 times, most recently from 24f2e4f to e61bab1 Compare December 28, 2024 05:03
@rgmz

This comment was marked as resolved.

@rgmz rgmz force-pushed the tests/privatekey branch 9 times, most recently from c0947d9 to 625d9e9 Compare December 28, 2024 20:43
@rgmz rgmz marked this pull request as ready for review December 28, 2024 20:45
@rgmz rgmz merged commit 24d890f into main Dec 28, 2024
9 of 10 checks passed
@rgmz rgmz deleted the tests/privatekey branch December 28, 2024 21:15
@rgmz rgmz mentioned this pull request Dec 28, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant